demos: do not generate twice the HelpersDispatchTable #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HelpersDispatchTable.* are already generated by the encoder lib. Signed-off-by: Stéphane Cerveau <scerveau@igalia.com>
dabrain34
force-pushed
the
dab_fix_dispatch_table_ninja
branch
from
a9a55d9 to
ee25e85
Compare
zlatinski
approved these changes
Nov 9, 2024
|
TBH I am hoping once Vulkan Video APIs stabilize in the Vulkan SDK, that I can skip using the dispatch table + dll hookups in lieu of direct vulkan-1.lib C function calls. I suppose that may not happen in a while given how much this is still being actively developed, but long-term it would be nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HelpersDispatchTable.* are already generated by the encoder lib.