Content-Type is broken #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
|
The fix is valid, but type checks are not addressed (see #128). |
can you explain, I don't understand |
|
This check works well: https://github.com/nspcc-dev/send-fs-neo-org/blob/master/src/Home.tsx#L37 |
|
The idea was to separate checks and uploads, currently some files are uploaded and some not. Uploading takes time, checking content type does not, so you can check all files first and error out if anything is wrong or upload all of them if everything is OK. |
|
OK, you have convinced me they're already separated, but there is an additional type to handle. Refs. nspcc-dev/neofs-oauthz#68 as well. |
Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
|
@roman-khimov done |
roman-khimov
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #128
Signed-off-by: Mikhail Petrov mike@nspcc.ru