Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

null-versioning and corresponding handler #134

Merged
merged 1 commit into from
Jul 6, 2021
Merged

null-versioning and corresponding handler #134

merged 1 commit into from
Jul 6, 2021

Conversation

masterSplinter01
Copy link
Contributor

@masterSplinter01 masterSplinter01 commented Jul 5, 2021 •
edited
Loading

Closes #119

@KirillovDenis
Copy link
Contributor

Should we mention #119 ?

KirillovDenis
KirillovDenis reviewed Jul 5, 2021
View reviewed changes
api/handler/list.go
Description: err.Error(),
HTTPStatusCode: http.StatusBadRequest,
}, r.URL)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we should add return statement to avoid further execution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

KirillovDenis
KirillovDenis reviewed Jul 5, 2021
View reviewed changes
api/handler/list.go Outdated

info, err := h.obj.ListObjectVersions(r.Context(), p)
if err != nil {
h.log.Error("something went wrong",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth moving the error writing response into a separate function.

Copy link
Contributor Author

@masterSplinter01 masterSplinter01 Jul 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this into a separate function

@masterSplinter01 masterSplinter01 force-pushed the feature/102-add-versioning-for-benchmark branch 3 times, most recently from ffb5264 to 719e9ae Compare July 5, 2021 19:54
@masterSplinter01 masterSplinter01 changed the title WIP: null-versioning and corresponding handler null-versioning and corresponding handler Jul 6, 2021
alexvanin
alexvanin reviewed Jul 6, 2021
View reviewed changes
@masterSplinter01
[#119] Add null versioning and handler
f3c74fa 
Signed-off-by: Angira Kekteeva <kira@nspcc.ru>
@masterSplinter01 masterSplinter01 force-pushed the feature/102-add-versioning-for-benchmark branch from 719e9ae to f3c74fa Compare July 6, 2021 09:14
@alexvanin alexvanin merged commit c1cd769 into nspcc-dev:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KirillovDenis KirillovDenis KirillovDenis left review comments

@alexvanin alexvanin alexvanin approved these changes

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add null-versioning of objects and corresponding handler
3 participants
@masterSplinter01 @KirillovDenis @alexvanin