Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XMLName field for CompleteMultipartUpload #1077

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

smallhive
Copy link
Contributor

Gitlab doesn't send this field and AWS docs doesn't say the field is mandatory.

Closes #1074.

@smallhive smallhive force-pushed the 1074-gitlab-cant-upload-multipart-file branch 2 times, most recently from 10f1c4e to 5df5cc1 Compare February 24, 2025 11:04
@smallhive smallhive force-pushed the 1074-gitlab-cant-upload-multipart-file branch from 5df5cc1 to 2020b58 Compare February 25, 2025 04:59
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other structures used for responses among those changed in this PR?

Amazon s3 works perfectly without xmlns.

Closes #1074.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive force-pushed the 1074-gitlab-cant-upload-multipart-file branch from 2020b58 to c1ff1f0 Compare March 3, 2025 11:15
@smallhive smallhive requested a review from roman-khimov March 3, 2025 11:16
@roman-khimov roman-khimov merged commit 04b2c71 into master Mar 3, 2025
9 of 18 checks passed
@roman-khimov roman-khimov deleted the 1074-gitlab-cant-upload-multipart-file branch March 3, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab can't upload multipart file
2 participants