Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Remove tree service for object operations #1050

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

smallhive
Copy link
Contributor

@smallhive smallhive commented Dec 27, 2024

Refs #902

@smallhive smallhive force-pushed the 902-replace-tree-service-for-objects-0 branch from 2a654a1 to 9585120 Compare January 9, 2025 11:01
@smallhive smallhive force-pushed the 902-replace-tree-service-for-objects-0 branch 3 times, most recently from 8c95c7d to 3d72e17 Compare January 21, 2025 11:08
@smallhive smallhive changed the title *: Remove tree *: Remove tree service for object operations Jan 21, 2025
@smallhive smallhive marked this pull request as ready for review January 21, 2025 11:08
@smallhive smallhive force-pushed the 902-replace-tree-service-for-objects-0 branch from 3d72e17 to 819c033 Compare January 24, 2025 10:16
Refs #902.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
gofmt  File is not `gofmt`-ed with `-s` `-r 'interface{} -> any'`.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive force-pushed the 902-replace-tree-service-for-objects-0 branch from 819c033 to cbe53f6 Compare January 27, 2025 05:39
return nil, fmt.Errorf("couldn't head object: %w", err)
}

// if head.Type() == object.TypeTombstone || head.Type() == object.TypeLink || head.Type() == object.TypeLock {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this commented out code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use object-type filter instead, commend is removed

@roman-khimov roman-khimov merged commit 7141b84 into master Jan 30, 2025
12 of 18 checks passed
@roman-khimov roman-khimov deleted the 902-replace-tree-service-for-objects-0 branch January 30, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetObject: can't get object under not owner user even when correct ACL were set
2 participants