This repository was archived by the owner on Mar 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #35 from realloc/readmez
Improve first contribution experience
- Loading branch information
Showing
9 changed files
with
1,058 additions
and
675 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
--- | ||
name: Bug report | ||
about: Create a report to help us improve | ||
title: '' | ||
labels: community, triage | ||
assignees: '' | ||
|
||
--- | ||
|
||
<!--- Provide a general summary of the issue in the Title above --> | ||
|
||
## Expected Behavior | ||
<!--- If you're describing a bug, tell us what should happen --> | ||
<!--- If you're suggesting a change/improvement, tell us how it should work --> | ||
|
||
## Current Behavior | ||
<!--- If describing a bug, tell us what happens instead of the expected behavior --> | ||
<!--- If suggesting a change/improvement, explain the difference from current behavior --> | ||
|
||
## Possible Solution | ||
<!--- Not obligatory, but suggest a fix/reason for the bug, --> | ||
<!--- or ideas how to implement the addition or change --> | ||
|
||
## Steps to Reproduce (for bugs) | ||
<!--- Provide a link to a live example, or an unambiguous set of steps to --> | ||
<!--- reproduce this bug. --> | ||
|
||
1. | ||
2. | ||
3. | ||
4. | ||
|
||
## Context | ||
<!--- How has this issue affected you? What are you trying to accomplish? --> | ||
<!--- Providing context helps us come up with a solution that is most useful in the real world --> | ||
|
||
## Regression | ||
<!-- Is this issue a regression? (Yes / No) --> | ||
<!-- If Yes, optionally please include version or commit id or PR# that caused this regression, if you have these details. --> | ||
|
||
## Your Environment | ||
<!--- Include as many relevant details about the environment you experienced the bug in --> | ||
* Version used: | ||
* Server setup and configuration: | ||
* Operating System and version (`uname -a`): |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
blank_issues_enabled: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
title: '' | ||
labels: community, triage | ||
assignees: '' | ||
|
||
--- | ||
|
||
**Is your feature request related to a problem? Please describe.** | ||
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] | ||
|
||
**Describe the solution you'd like** | ||
A clear and concise description of what you want to happen. | ||
|
||
**Describe alternatives you've considered** | ||
A clear and concise description of any alternative solutions or features you've considered. | ||
|
||
**Additional context** | ||
Add any other context or screenshots about the feature request here. |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
name: DCO check | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- master | ||
|
||
jobs: | ||
commits_check_job: | ||
runs-on: ubuntu-latest | ||
name: Commits Check | ||
steps: | ||
- name: Get PR Commits | ||
id: 'get-pr-commits' | ||
uses: tim-actions/get-pr-commits@master | ||
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
- name: DCO Check | ||
uses: tim-actions/dco@master | ||
with: | ||
commits: ${{ steps.get-pr-commits.outputs.commits }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,156 @@ | ||
# Contribution guide | ||
|
||
First, thank you for contributing! We love and encourage pull requests from | ||
everyone. Please follow the guidelines: | ||
|
||
- Check the open [issues](https://github.com/nspcc-dev/neofs-http-gate/issues) and | ||
[pull requests](https://github.com/nspcc-dev/neofs-http-gate/pulls) for existing | ||
discussions. | ||
|
||
- Open an issue first, to discuss a new feature or enhancement. | ||
|
||
- Write tests, and make sure the test suite passes locally and on CI. | ||
|
||
- Open a pull request, and reference the relevant issue(s). | ||
|
||
- Make sure your commits are logically separated and have good comments | ||
explaining the details of your change. | ||
|
||
- After receiving feedback, amend your commits or add new ones as | ||
appropriate. | ||
|
||
- **Have fun!** | ||
|
||
## Development Workflow | ||
|
||
Start by forking the `neofs-http-gate` repository, make changes in a branch and then | ||
send a pull request. We encourage pull requests to discuss code changes. Here | ||
are the steps in details: | ||
|
||
### Set up your GitHub Repository | ||
Fork [NeoFS HTTP Protocol Gateway | ||
upstream](https://github.com/nspcc-dev/neofs-http-gate/fork) source repository | ||
to your own personal repository. Copy the URL of your fork (you will need it for | ||
the `git clone` command below). | ||
|
||
```sh | ||
$ git clone https://github.com/nspcc-dev/neofs-http-gate | ||
``` | ||
|
||
### Set up git remote as ``upstream`` | ||
```sh | ||
$ cd neofs-http-gate | ||
$ git remote add upstream https://github.com/nspcc-dev/neofs-http-gate | ||
$ git fetch upstream | ||
$ git merge upstream/master | ||
... | ||
``` | ||
|
||
### Create your feature branch | ||
Before making code changes, make sure you create a separate branch for these | ||
changes. Maybe you will find it convenient to name branch in | ||
`<type>/<Issue>-<changes_topic>` format. | ||
|
||
``` | ||
$ git checkout -b feature/123-something_awesome | ||
``` | ||
|
||
### Test your changes | ||
After your code changes, make sure | ||
|
||
- To add test cases for the new code. | ||
- To run `make lint` | ||
- To squash your commits into a single commit or a series of logically separated | ||
commits run `git rebase -i`. It's okay to force update your pull request. | ||
- To run `make test` and `make all` completes. | ||
|
||
### Commit changes | ||
After verification, commit your changes. This is a [great | ||
post](https://chris.beams.io/posts/git-commit/) on how to write useful commit | ||
messages. Try following this template: | ||
|
||
``` | ||
[#Issue] <component> Summary | ||
Description | ||
<Macros> | ||
<Sign-Off> | ||
``` | ||
|
||
``` | ||
$ git commit -am '[#123] Add some feature' | ||
``` | ||
|
||
### Push to the branch | ||
Push your locally committed changes to the remote origin (your fork) | ||
``` | ||
$ git push origin feature/123-something_awesome | ||
``` | ||
|
||
### Create a Pull Request | ||
Pull requests can be created via GitHub. Refer to [this | ||
document](https://help.github.com/articles/creating-a-pull-request/) for | ||
detailed steps on how to create a pull request. After a Pull Request gets peer | ||
reviewed and approved, it will be merged. | ||
|
||
## DCO Sign off | ||
|
||
All authors to the project retain copyright to their work. However, to ensure | ||
that they are only submitting work that they have rights to, we are requiring | ||
everyone to acknowledge this by signing their work. | ||
|
||
Any copyright notices in this repository should specify the authors as "the | ||
contributors". | ||
|
||
To sign your work, just add a line like this at the end of your commit message: | ||
|
||
``` | ||
Signed-off-by: Samii Sakisaka <samii@nspcc.ru> | ||
``` | ||
|
||
This can easily be done with the `--signoff` option to `git commit`. | ||
|
||
By doing this you state that you can certify the following (from [The Developer | ||
Certificate of Origin](https://developercertificate.org/)): | ||
|
||
``` | ||
Developer Certificate of Origin | ||
Version 1.1 | ||
Copyright (C) 2004, 2006 The Linux Foundation and its contributors. | ||
1 Letterman Drive | ||
Suite D4700 | ||
San Francisco, CA, 94129 | ||
Everyone is permitted to copy and distribute verbatim copies of this | ||
license document, but changing it is not allowed. | ||
Developer's Certificate of Origin 1.1 | ||
By making a contribution to this project, I certify that: | ||
(a) The contribution was created in whole or in part by me and I | ||
have the right to submit it under the open source license | ||
indicated in the file; or | ||
(b) The contribution is based upon previous work that, to the best | ||
of my knowledge, is covered under an appropriate open source | ||
license and I have the right under that license to submit that | ||
work with modifications, whether created in whole or in part | ||
by me, under the same open source license (unless I am | ||
permitted to submit under a different license), as indicated | ||
in the file; or | ||
(c) The contribution was provided directly to me by some other | ||
person who certified (a), (b) or (c) and I have not modified | ||
it. | ||
(d) I understand and agree that this project and the contribution | ||
are public and that a record of the contribution (including all | ||
personal information I submit with it, including my sign-off) is | ||
maintained indefinitely and may be redistributed consistent with | ||
this project or the open source license(s) involved. | ||
``` |
Oops, something went wrong.