Makefile: use static revision for openflights data #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's very rarely changed, so it's not a problem. And we can have a bit less surpises and also close #13 since after this change we no longer have any simple files to download, they're all coming from github with known revisions. If Github is to return something different and we can't trust it any additional checks would be meaningless anyway. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
requested review from
carpawell,
cthulhu-rider and
AliceInHunterland
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 27.20% 27.20%
=======================================
Files 21 21
Lines 952 952
=======================================
Hits 259 259
Misses 668 668
Partials 25 25 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very rarely changed, so it's not a problem. And we can have a bit less surpises and also close #13 since after this change we no longer have any simple files to download, they're all coming from github with known revisions. If Github is to return something different and we can't trust it any additional checks would be meaningless anyway.