Use continents from known source #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
carpawell,
cthulhu-rider,
roman-khimov and
AliceInHunterland
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
=======================================
Coverage 28.75% 28.75%
=======================================
Files 21 21
Lines 793 793
=======================================
Hits 228 228
Misses 540 540
Partials 25 25 ☔ View full report in Codecov by Sentry. |
|
Please mention that it's MIT-licensed in the commit message. |
Use continents file from https://gist.github.com/hrbrmstr/91ea5cc9474286c72838, which has MIT License. Closes #19. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Update `pkg/locodedb/data/locodes.csv.bz2` with new continents file from https://gist.github.com/hrbrmstr/91ea5cc9474286c72838. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
19-reuse-public-continents-db
branch
from
61f3569 to
ad05c2a
Compare
roman-khimov
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #19.
Use continents file from https://gist.github.com/hrbrmstr/91ea5cc9474286c72838.
Difference in
pkg/locodedb/data/locodes.csv: