Go 1.22 #43
Merged
Go 1.22 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop 1.21 and use 1.23 for test. Closes #31. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
requested review from
carpawell,
cthulhu-rider,
roman-khimov and
AliceInHunterland
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 25.94% 28.97% +3.02%
==========================================
Files 23 23
Lines 767 787 +20
==========================================
+ Hits 199 228 +29
- Misses 533 534 +1
+ Partials 35 25 -10 ☔ View full report in Codecov by Sentry. |
``` WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar. ``` Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
31-go-122-upgrade-check-list
branch
from
8a9dd24 to
d31aef2
Compare
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
|
Yeah, please update ubuntu as well. |
roman-khimov
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31.
Do I need to update the ubuntu version to the latest in workflow?