Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: extract identifiers, globalconf generated code out of common-util #1968

Merged
merged 9 commits into from
Feb 22, 2024
Merged

chore: extract identifiers, globalconf generated code out of common-util #1968

merged 9 commits into from
Feb 22, 2024

Conversation

ricardas-buc
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
src build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate 8.5 ❌ Build Scan NOT_PUBLISHED

@ricardas-buc ricardas-buc marked this pull request as ready for review February 21, 2024 15:00
@github-actions GitHub Actions
Copy link

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
src build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate 8.5 ❌ Build Scan NOT_PUBLISHED

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
src build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate 8.5 ❌ Build Scan NOT_PUBLISHED

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
src build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate 8.5 ❌ Build Scan NOT_PUBLISHED

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
src build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate 8.5 ❌ Build Scan NOT_PUBLISHED

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
src build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate 8.5 ❌ Build Scan NOT_PUBLISHED

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 New Critical Issues (required ≤ 0)
3 New Blocker Issues (required ≤ 0)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

X-Road tests :: BuildAndPackageWithUnitTests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
src build sonar test intTest runProxyTest runMetaserviceTest runProxymonitorMetaserviceTest jacocoTestReport dependencyCheckAggregate 8.5 ✅ Build Scan NOT_PUBLISHED

ovidijusnortal
ovidijusnortal approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@ovidijusnortal ovidijusnortal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, vavr changes also seem to match Optional API

@ricardas-buc ricardas-buc merged commit 1244414 into develop Feb 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovidijusnortal ovidijusnortal ovidijusnortal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardas-buc @ovidijusnortal