Skip to content

Commit

Permalink
fix: make sonar happy
Browse files Browse the repository at this point in the history
Closes: XRDDEV-2620
  • Loading branch information
ovidijusnortal committed May 8, 2024
1 parent 36aa3a5 commit 4f2aa48
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,36 +30,44 @@

import org.hibernate.HibernateException;
import org.hibernate.cfg.Configuration;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
import org.mockito.MockedStatic;
import org.mockito.Mockito;
import org.mockito.junit.jupiter.MockitoExtension;

import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.fail;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.CALLS_REAL_METHODS;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

@ExtendWith(MockitoExtension.class)
class HibernateUtilTest {
private static final String TEST_SESSION_FACTORY_NAME = "testSessionFactory";

@Mock
private Configuration configuration;

@BeforeEach
public void setUp() {
when(configuration.configure()).thenReturn(configuration);
when(configuration.configure(anyString())).thenReturn(configuration);
}

@Test
void getSessionFactoryHideErrorDetails() {

try (
MockedStatic<HibernateUtil> db = Mockito.mockStatic(HibernateUtil.class, CALLS_REAL_METHODS);
MockedStatic<SystemProperties> system = Mockito.mockStatic(SystemProperties.class)
) {
var config = mock(Configuration.class);
db.when(HibernateUtil::createEmptyConfiguration).thenReturn(config);
db.when(HibernateUtil::createEmptyConfiguration).thenReturn(configuration);
system.when(SystemProperties::getDatabasePropertiesFile)
.thenReturn(HibernateUtilTest.class.getResource("/empty_db.properties").getFile());
when(config.configure())
.thenReturn(config);
when(config.buildSessionFactory())
when(configuration.buildSessionFactory())
.thenThrow(new HibernateException("username and ip address"));
HibernateUtil.getSessionFactory(TEST_SESSION_FACTORY_NAME);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ protected void failure(MessageProcessorBase processor, Request request, Response
}

protected void failure(Response response, Callback callback, CodedExceptionWithHttpStatus e,
OpMonitoringData opMonitoringData) throws IOException {
OpMonitoringData opMonitoringData) {

updateOpMonitoringResponseOutTs(opMonitoringData);

Expand Down

0 comments on commit 4f2aa48

Please sign in to comment.