lookup: skip graceful-fs on >=11

[targos]

Some tests fail because of GC-related changes.

[codecov-io]

Codecov Report

Merging #655 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #655   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          26       26           
  Lines         823      823           
=======================================
  Hits          777      777           
  Misses         46       46

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a3d2dc...4650873. Read the comment docs.

[mcollina]

Do you remember what was decided during the latest breakage of graceful-fs?

We might need to open an issue there and get this fixed.

cc @addaleax.

[targos]

Feel free to open an issue there, I agree it should be done. In the mean time, I want to get CITGM runs green again. Otherwise it's too difficult to determine if a change in core introduces new breakages.

[mcollina]

I tend to disagree with the overall approach. Skipping modules that fails provides a false sense of security “but citgm was green!”
On the other end not skipping them make the tool less reliable.

I think we should open an issue “Ecosystem modules that will break on Node 12.0.0” in core, and append these to the list. So that we keep track of what has been skipped and must be fixed.

[targos]

I think we should open an issue “Ecosystem modules that will break on Node 12.0.0” in core, and append these to the list. So that we keep track of what has been skipped and must be fixed.

SGTM

[addaleax]

@mcollina This is a different kind of breakage than the issues we were having with them hooking into our internals – see isaacs/node-graceful-fs#137 for the root cause here

[targos]

@mcollina I opened nodejs/node#25060. LGTY?

[mcollina]

LGTM

[mcollina]

lol nodejs/node#25059 ;).