Rewrite bash wrapper in Amber #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thesola10
force-pushed
the
amber-ng
branch
2 times, most recently
from
76a296f to
cae95a7
Compare
|
Due to it being based on Amber 0.4.0, this version currently introduces a hard dependency to |
Thesola10
force-pushed
the
amber-ng
branch
2 times, most recently
from
4482661 to
873eaf4
Compare
Thesola10
force-pushed
the
amber-ng
branch
2 times, most recently
from
ab29f60 to
8538813
Compare
Thesola10
force-pushed
the
amber-ng
branch
2 times, most recently
from
a6687e0 to
45b1c8c
Compare
Also removes the need for the "ensure used" marker
Thesola10
force-pushed
the
amber-ng
branch
2 times, most recently
from
fcb930d to
6b26d37
Compare
Thesola10
force-pushed
the
amber-ng
branch
3 times, most recently
from
f4c9aff to
cd7129d
Compare
Thesola10
force-pushed
the
amber-ng
branch
3 times, most recently
from
3cfbf23 to
c612372
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the Nix wrapper script (
nix-wrapped.sh.in) is a monolithic, 600 lines of handwritten Bash. This in turn is an issue when it comes to maintainability of a pivotal part of Nixie.Rewriting everything in the Amber compiled language brings with it several improvements:
This PR also overhauls the Python build system by moving the Python module at the root of the repository, and switching to Hatch from Setuptools as a build backend.