Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swaylock: accept path type for settings values #6607

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

GaetanLepage
Copy link
Member

@GaetanLepage GaetanLepage commented Mar 12, 2025

Description

Currently, path values are not accepted as programs.swaylock.settings values:

error: A definition for option `home-manager.users.gaetan.programs.swaylock.settings.image' is not of type `boolean or floating point number or signed integer or string'.

This would allow for:

programs.swaylock = {
  enable = true;

  settings.image = ./wallpaper.png;
};

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

cc @rcerc

@khaneliman khaneliman merged commit dd41a39 into nix-community:master Mar 12, 2025
3 checks passed
@GaetanLepage GaetanLepage deleted the swaylock branch March 12, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants