-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed SearchBar width constantly changing in Safari #160
Conversation
When testing, test also on mobile widths, and with long content there. |
Seems fine in chromium for Windows. IssuesLong contentFor the long content something like this seems to work: .cross-close-button {
right: 1rem;
}
input {
padding-right: 4rem;
} Mobile + StakingMaybe hide the staking button and the three dots menu when search bar is focussed? Maybe too complex CSS 🤔 // src/components/SearchBar.vue - Note that this is another style tag and it is not scoped to the component
<style>
.actions-mobile:has(input.search-bar:focus-within) :is(.reset.icon-button,.prestaking-button) {
opacity: 0;
}
</style> |
Thanks for the feedback @sisou @onmax No more issues with long contentSearchBar on Mobile takes all spaceIn small phones there was problems when you have the cashlink button + staking + 3 dots, now everything to the right of the searchbar will be set to ExtraAlso made some improvements on how the placeholder text is calculated (tested and working in Safari) |
Tiny detail: There is a pixel shift to the top on mobile when you focus the input on mobiles Recording.2024-04-29.153218.mp4(Put attention to the to left of the input to see the bug). I tried to debug it but not sure where the problem is:
It is a very tiny thing, so not sure if we want to tackle this now :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks good to me. Tested it on Safari and it works as expected. Nice 👍 The only things that bothered me was the "feel" from the transitions, which I tried to finetune and I think it feels better now. |
Too much JS computation, let CSS work its black magic Tweaked max-width duration value to achieve the same animation effect
- now transitioning from and to the real min-width instead of 0, which was adding a delay in the visual transition. - finetuned transition timings
892030a
to
9a08d1f
Compare
Too much JS computation, let CSS work its black magic
Tweaked max-width duration value to achieve the same animation effect
Reported error:
Screen.Recording.2024-04-19.at.20.35.17.mov
Fixed:
Screen.Recording.2024-04-20.at.21.10.19.mov
Tested Safari and Brave on macOS. Please test on other OS.