Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI style adaptions #269

Merged
merged 27 commits into from
Apr 29, 2019
Merged

UI style adaptions #269

merged 27 commits into from
Apr 29, 2019

Conversation

sisou
Copy link
Member

@sisou sisou commented Apr 15, 2019 •
edited
Loading

Implements various style adaptions from nimiq/hub#182.

@sisou sisou requested review from Bettelstab and nibhar April 15, 2019 14:13
@sisou sisou self-assigned this Apr 15, 2019
@sisou sisou force-pushed the soeren/nimiq-style-update branch from 968670f to 4b97da1 Compare April 16, 2019 08:15
@sisou sisou force-pushed the soeren/nimiq-style-update branch from ce4bdf9 to 79717cf Compare April 17, 2019 19:00
@sisou sisou changed the title Use new input styles from @nimiq/style UI style adaptions Apr 17, 2019
@sisou sisou requested a review from Bettelstab April 17, 2019 22:10
@sisou sisou force-pushed the soeren/nimiq-style-update branch from ccab322 to 157b164 Compare April 17, 2019 22:14
@sisou sisou mentioned this pull request Apr 18, 2019
Closed
82 tasks
nibhar
nibhar requested changes Apr 18, 2019
View reviewed changes
Copy link
Member

@nibhar nibhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes.

I hope I found the things that are to be found but I would say someone else should try everything out, too, to be safe.

src/request/remove-key/remove-key.css
.page#remove-key .page-body {
display: flex;
flex-flow: row wrap;
justify-content: center;
}

.page#remove-key .page-footer button {
margin-top: 0;
width: calc(100% - 7rem);
margin: 3.5rem auto 3rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remind me to change this in the passwordBox update transition ;)

Bettelstab
Bettelstab suggested changes Apr 20, 2019
View reviewed changes
Copy link
Contributor

@Bettelstab Bettelstab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can happen, but should not:

image

I have no glue what's happening there. I can not even reproduce it always, but sometimes...

@sisou sisou mentioned this pull request Apr 25, 2019
Merged
@sisou
Copy link
Member Author

sisou commented Apr 25, 2019 •
edited
Loading

@Bettelstab without a reproducable set of steps to create this situation, it's really not that helpful. I have tried for 15 minutes now to get what you are seeing, but I cannot.

Are you sure you where up-to-date in the commits and ran yarn?

@Bettelstab
Copy link
Contributor

http://drive.nim.team/s/BY4sRwXn6kLcH3R
up to date.
That's not a blocker I would say, but weird.

@sisou
Fix color of wrong-words label
99be0d0 
The specificity in nimiq-styles is not sufficient.
@sisou sisou requested review from nibhar and Bettelstab April 29, 2019 09:15
@sisou
Copy link
Member Author

sisou commented Apr 29, 2019

The word import style issues seems to be happening when cutting a word from it's input, yes? E.g. with CTRL+X. This does not happen in my Chrome (Fedora), so this might be an issue specific to MacOS not sending an input event or similar after cutting. I will ignore this in this PR, however.

@sisou sisou force-pushed the soeren/nimiq-style-update branch from 5fc960d to 2ea61db Compare April 29, 2019 09:19
@sisou
Copy link
Member Author

sisou commented Apr 29, 2019

@Bettelstab input field style problem is tracked in #279.

@sisou sisou merged commit 1376dd7 into master Apr 29, 2019
@sisou sisou deleted the soeren/nimiq-style-update branch April 29, 2019 11:46
@sisou sisou mentioned this pull request May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nibhar nibhar nibhar approved these changes

@Bettelstab Bettelstab Awaiting requested review from Bettelstab

Assignees

@sisou sisou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sisou @Bettelstab @nibhar