Return file/words flags when importing and removing keys #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 13, 2019
danimoh
requested changes
Mar 13, 2019
sisou
force-pushed
the
soeren/result-flags
branch
2 times, most recently
from
b94dc00 to
22e68e5
Compare
sisou
force-pushed
the
soeren/result-flags
branch
from
22e68e5 to
b39ad68
Compare
sisou
force-pushed
the
soeren/result-flags
branch
from
b39ad68 to
b267743
Compare
|
The new changes also look good to me, only the one unresolved discussion remains |
sisou
force-pushed
the
soeren/result-flags
branch
from
b267743 to
0ec8840
Compare
Bettelstab
approved these changes
Mar 18, 2019
danimoh
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the required feedback to the import results for nimiq/hub#156.