Skip to content

Use Blake2b to make comparison constant-time wrt. password length #100

Use Blake2b to make comparison constant-time wrt. password length

Use Blake2b to make comparison constant-time wrt. password length #100

GitHub Actions / Clippy Report succeeded May 20, 2024 in 0s

Clippy Report

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check warning on line 122 in server/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

this returns a `Result<_, ()>`

warning: this returns a `Result<_, ()>`
   --> server/src/lib.rs:122:5
    |
122 |     pub fn verify<T: AsRef<str>, U: AsRef<str>>(&self, username: T, password: U) -> Result<(), ()> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: use a custom `Error` type instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
    = note: `#[warn(clippy::result_unit_err)]` on by default

Check warning on line 113 in client/src/wasm_websocket.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
   --> client/src/wasm_websocket.rs:113:24
    |
113 |         let ready_tx = Arc::new(RefCell::new(Some(ready_tx)));
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `Arc<RefCell<Option<Sender<()>>>>` is not `Send` and `Sync` as:
    = note: - the trait `Sync` is not implemented for `RefCell<Option<Sender<()>>>`
    = help: consider using an `Rc` instead. `Arc` does not provide benefits for non `Send` and `Sync` types
    = note: if you intend to use `Arc` with `Send` and `Sync` traits
    = note: wrap the inner type with a `Mutex` or implement `Send` and `Sync` for `RefCell<Option<Sender<()>>>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
    = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

Check warning on line 122 in server/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

this returns a `Result<_, ()>`

warning: this returns a `Result<_, ()>`
   --> server/src/lib.rs:122:5
    |
122 |     pub fn verify<T: AsRef<str>, U: AsRef<str>>(&self, username: T, password: U) -> Result<(), ()> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: use a custom `Error` type instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
    = note: `#[warn(clippy::result_unit_err)]` on by default

Check warning on line 122 in server/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

this returns a `Result<_, ()>`

warning: this returns a `Result<_, ()>`
   --> server/src/lib.rs:122:5
    |
122 |     pub fn verify<T: AsRef<str>, U: AsRef<str>>(&self, username: T, password: U) -> Result<(), ()> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: use a custom `Error` type instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err
    = note: `#[warn(clippy::result_unit_err)]` on by default