Skip to content

Store decompressed BlsPublicKeys in IndexedDB #14429

Store decompressed BlsPublicKeys in IndexedDB

Store decompressed BlsPublicKeys in IndexedDB #14429

GitHub Actions / Clippy Report succeeded Jan 27, 2025 in 0s

Clippy Report

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.84.0 (9fc6b4312 2025-01-07)
  • cargo 1.84.0 (66221abde 2024-11-19)
  • clippy 0.1.84 (9fc6b43126 2025-01-07)

Annotations

Check warning on line 1126 in web-client/src/client/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

this `RefCell` reference is held across an await point

warning: this `RefCell` reference is held across an await point
    --> web-client/src/client/lib.rs:1126:47
     |
1126 | ...                   if let Err(err) = bls_cache.borrow_mut().add_keys(bls_keys).await {
     |                                         ^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: ensure the reference is dropped before calling `await`
note: these are all the await points this reference is held through
    --> web-client/src/client/lib.rs:1126:89
     |
1126 | ...                   if let Err(err) = bls_cache.borrow_mut().add_keys(bls_keys).await {
     |                                                                                   ^^^^^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref

Check warning on line 211 in web-client/src/client/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

this `RefCell` reference is held across an await point

warning: this `RefCell` reference is held across an await point
   --> web-client/src/client/lib.rs:211:27
    |
211 |         if let Err(err) = client.bls_cache.borrow_mut().init().await {
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: ensure the reference is dropped before calling `await`
note: these are all the await points this reference is held through
   --> web-client/src/client/lib.rs:211:64
    |
211 |         if let Err(err) = client.bls_cache.borrow_mut().init().await {
    |                                                                ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_refcell_ref
    = note: `#[warn(clippy::await_holding_refcell_ref)]` on by default

Check warning on line 26 in network-libp2p/src/network_metrics.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
  --> network-libp2p/src/network_metrics.rs:26:44
   |
26 |             response_times: Histogram::new([0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1.0, 2.0].into_iter()),
   |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `[0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1.0, 2.0]`
   |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/prometheus-client-0.23.1/src/metrics/histogram.rs:65:30
   |
65 |     pub fn new(buckets: impl IntoIterator<Item = f64>) -> Self {
   |                              ^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default