Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: Make blocks' body hash non-optional, as it's always provided #3305

Open
wants to merge 1 commit into
base: albatross
Choose a base branch
from
Open

RPC: Make blocks' body hash non-optional, as it's always provided #3305

wants to merge 1 commit into from

Conversation

sisou
Copy link
Member

@sisou sisou commented Feb 27, 2025 •
edited
Loading

This doesn't change anything in the RPC response, as before this field was always a string (never null), and that's the same now.

@sisou sisou added the enhancement New feature or request label Feb 27, 2025
@sisou sisou requested review from jsdanielh and Eligioo February 27, 2025 15:15
@sisou sisou self-assigned this Feb 27, 2025
jsdanielh
jsdanielh approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@jsdanielh jsdanielh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdanielh jsdanielh jsdanielh approved these changes

@Eligioo Eligioo Awaiting requested review from Eligioo

Assignees

@sisou sisou

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sisou @jsdanielh