Pico consensus #3285
Open
Pico consensus #3285
+1,272
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viquezclaudio
force-pushed
the
viquezcl/pico-consensus
branch
8 times, most recently
from
872c575 to
29a54cf
Compare
jsdanielh
reviewed
Feb 13, 2025
consensus/src/sync/light/mod.rs
Outdated
| @@ -4,4 +4,4 @@ mod sync_stream; | |||
| #[cfg(feature = "full")] | |||
| mod validity_window; | |||
|
|
|||
| pub use sync::LightMacroSync; | |||
| pub use sync::{EpochIds, LightMacroSync, PeerMacroRequests}; | |||
There was a problem hiding this comment.
Why do we need to make it public?
There was a problem hiding this comment.
Because they need to be accesible from the pico variant, otherwise:
rror[E0432]: unresolved imports `crate::sync::light::EpochIds`, `crate::sync::light::PeerMacroRequests`
--> consensus/src/sync/pico/sync_requests.rs:17:17
|
17 | light::{EpochIds, PeerMacroRequests},
| ^^^^^^^^ ^^^^^^^^^^^^^^^^^ no `PeerMacroRequests` in `sync::light`
| |
| no `EpochIds` in `sync::light`
|
note: these structs exist but are inaccessible
There was a problem hiding this comment.
Another option would be to move those structs to some shared file between light and macro sync
There was a problem hiding this comment.
Yeah, to me it means they maybe don't belong here
| )); | ||
| } | ||
| } else { | ||
| // We only accept macro blocks from the current epoch |
There was a problem hiding this comment.
Shouldn't we check this is a macro block?
|
Could you also consider adding a pico node to the devnet scenarios? I think it would be valuable to test it as well |
viquezclaudio
force-pushed
the
viquezcl/pico-consensus
branch
2 times, most recently
from
8e4b560 to
ba33b5e
Compare
The PicoMacroSync is a macro sync mechanism that pushes the latest election block that is obtained from a peer, if subsequent (sufficient) peers also have the same latest election (and latest checkpoint blocks) then we move all the peers to live sync and we establish consensus. If some peer has a different state than the initial state we obtained, we need to fallback to the regular light macro sync.
viquezclaudio
force-pushed
the
viquezcl/pico-consensus
branch
from
ba33b5e to
cd63bab
Compare
Create a sync_interface file where common functionality from the different sync implementations can be imported
viquezclaudio
force-pushed
the
viquezcl/pico-consensus
branch
from
e750ddc to
b1b7cdd
Compare
jsdanielh
reviewed
Feb 15, 2025
viquezclaudio
force-pushed
the
viquezcl/pico-consensus
branch
from
3ab735b to
da6079e
Compare
When processing epoch ids it could happen that by the time we requested the epoch ids and the time we received those we no longer have anything new to learn from the peer, so we emit it as good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pico Consensus Implementation
The PicoMacroSync is a macro sync mechanism that pushes the latest election block
that is obtained from a peer, if subsequent (sufficient) peers also have the same latest election
(and latest checkpoint blocks) then we move all the peers to live sync and we establish consensus.
If some peer has a different state than the initial state we obtained, we need to fallback to the
regular light macro sync.
To use it or try it in the web client:
web-client/src/client/lib.rs
let mut config = builder.volatile().pico().build().expect("Build configuration failed");You can also set consensus sync mode to 'pico' if you want to test it in a light client
Pull request checklist
clippyandrustfmtwarnings.