Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC server: add option to configure CORS origins #3258

Merged
merged 1 commit into from
Jan 30, 2025

RPC server: add option to configure CORS origins

72cd684
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

RPC server: add option to configure CORS origins #3258

RPC server: add option to configure CORS origins
72cd684
Select commit
Loading
Failed to load commit list.
GitHub Actions / Clippy Report succeeded Jan 30, 2025 in 1s

Clippy Report

1 warning

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 1
Note 0
Help 0

Versions

  • rustc 1.84.0 (9fc6b4312 2025-01-07)
  • cargo 1.84.0 (66221abde 2024-11-19)
  • clippy 0.1.84 (9fc6b43126 2025-01-07)

Annotations

Check warning on line 26 in network-libp2p/src/network_metrics.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Report

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
  --> network-libp2p/src/network_metrics.rs:26:44
   |
26 |             response_times: Histogram::new([0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1.0, 2.0].into_iter()),
   |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `[0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1.0, 2.0]`
   |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/prometheus-client-0.23.1/src/metrics/histogram.rs:65:30
   |
65 |     pub fn new(buckets: impl IntoIterator<Item = f64>) -> Self {
   |                              ^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default