-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable-sized Coin serialization #2373
Open
sisou
wants to merge
6
commits into
albatross
Choose a base branch
from
soeren/variable-size-coin
base: albatross
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrxi
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good improvement to me.
fc78f99
to
aa4382b
Compare
To de/serialize Coins to big-endian fixint for backwards-compatible vesting contract creation data.
Use the mirror function of `u64::from_be_bytes`, which is used when reading it.
8d391d9
to
c12d921
Compare
I think we decided not to do that because it's a breaking change. Is that correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This PR makes
Coin
serialize to a varint in transactions and accounts, both over the wire and their internal representations (history store).Reasoning
No transaction will likely ever make use of the full u64 range for its
value
, and especially not forfee
. So most zero bytes for Coins in most transactions are wasted. This is especially true for signaling transactions, which have 16 zero-bytes to represent 0 value and (mostly) 0 fee. This PR reduces them to two zero bytes.Drawbacks
Exceptions
There are two exceptions for backwards-compatibility with PoW transactions:
fixint::be
tx.serialize_content()
serializesvalue
andfee
as before withfixint::be
Pull request checklist
clippy
andrustfmt
warnings.