Remove associated type PubsubId from ValidatorNetwork
#2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdanielh
approved these changes
Jan 27, 2024
Instead a type alias is added. The reason is that before this the types of `TValidatorNetwork::PubsubId` and `TvalidatorNetwork::NetworkType::PubsubId` are not guaranteed to be the same. There would be other ways of enforcing this with additional traits but the alias seemed the easiest solution.
jsdanielh
force-pushed
the
nibhar/validator-pubsubid
branch
from
d5519a3 to
209e971
Compare
hrxi
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead a type alias is added.
The reason is that before this the types of
TValidatorNetwork::PubsubIdandTvalidatorNetwork::NetworkType::PubsubIdare not guaranteed to be the same. There would be other ways of enforcing this with additional traits but the alias seemed the easiest solution.