Add BlockchainEvent::Stored(Block) for forked and inferior chain blocks
#2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrxi
reviewed
Jan 26, 2024
nibhar
force-pushed
the
nibhar/blockchain-event
branch
from
51f25ee to
059734d
Compare
hrxi
force-pushed
the
nibhar/blockchain-event
branch
from
059734d to
e276ede
Compare
Also streamline the event firings in general. Any `Finalized` and `EpochFinalized` event does *not* supersede an `Extended` event. After this commit these will be emitted consistently. Note that the validator still must `on_blockchain_extended` for `EpochFinalized` as well as `Finalized` as the ordering of emitted events would otherwise matter since the validator set needs adjustment before the block producer is initialized.
hrxi
force-pushed
the
nibhar/blockchain-event
branch
from
e276ede to
6477bc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also streamline the event firings in general. Any
FinalizedandEpochFinalizedevent does not supersede anExtendedevent. After this commit these will be emitted consistently.Note that the validator still must
on_blockchain_extendedforEpochFinalizedas well asFinalizedas the ordering of emitted events would otherwise matter since the validator set needs adjustment before the block producer is initialized.