-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata before 1.4.9 release #2082
base: master
Are you sure you want to change the base?
Update metadata before 1.4.9 release #2082
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (83.02%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage. ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## master #2082 +/- ##
==========================================
- Coverage 91.34% 83.02% -8.32%
==========================================
Files 66 48 -18
Lines 16292 9556 -6736
==========================================
- Hits 14882 7934 -6948
- Misses 1410 1622 +212
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
src/nidigital/metadata/enums.py
Outdated
@@ -792,6 +792,22 @@ | |||
} | |||
] | |||
}, | |||
'VectorMemoryType': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no reason for these to be in the Python metadata, they aren't for public use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was surprised that private enums were included in the generated metadata, too.
We might need to update the plugin template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted it and I've got an internal PR to update the internal metadata so that this won't be included next time.
We'll just skip updating this metadata this time around, since there's no other changes.
I considered updating the internal template expander to exclude private access functions, attributes and enums,, but then I remembered the special case of the "internal" SetRuntimeEnvironment function that we include in our metadata and didn't want to risk breaking a similar case with "private" access.
This reverts commit b019eb9.
[ ] I've updated CHANGELOG.md if applicable.[ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Update metadata to latest final exports for most APIs.
Excluded:
Resulting Changes:
List issues fixed by this Pull Request below, if any.
None
What testing has been done?
PR Checks