Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata before 1.4.9 release #2082

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ni-jfitzger
Copy link
Collaborator

@ni-jfitzger ni-jfitzger commented Feb 24, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • [ ] I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

Update metadata to latest final exports for most APIs.

Excluded:

  • nise: no new final exports
  • nifgen, niswitch: .proto file changes are messy, so I'm handling it in a separate PR
  • nidigital: included nothing useful, along with something we didn't want, so I'm skipping it and creating an internal PR to update it for next time.

Resulting Changes:

  • nidmm has minor documentation changes
  • nidcpower: OUTPUT_STATES_NIDCPOWER_VAL_OUTPUT_INHIBITED add to nidcpower_pb2.py

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

PR Checks

@ni-jfitzger ni-jfitzger changed the title Update metadata before 1 4 9 release Update metadata before 1.4.9 release Feb 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.02%. Comparing base (93b5c85) to head (b038f91).
Report is 1 commits behind head on master.

❌ Your project status has failed because the head coverage (83.02%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (93b5c85) and HEAD (b038f91). Click for more details.

HEAD has 21 uploads less than BASE
Flag BASE (93b5c85) HEAD (b038f91)
nifakeunittests 5 2
nidcpowerunittests 4 2
nidigitalunittests 5 2
nimodinstunittests 5 2
niscopeunittests 5 2
nitclkunittests 5 2
niscopesystemtests 1 0
nifgensystemtests 1 0
nitclksystemtests 1 0
nidigitalsystemtests 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2082      +/-   ##
==========================================
- Coverage   91.34%   83.02%   -8.32%     
==========================================
  Files          66       48      -18     
  Lines       16292     9556    -6736     
==========================================
- Hits        14882     7934    -6948     
- Misses       1410     1622     +212     
Flag Coverage Δ
codegenunittests 84.95% <ø> (ø)
nidcpowersystemtests 85.35% <ø> (-9.21%) ⬇️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests ?
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 81.65% <ø> (-11.08%) ⬇️
nifakeunittests 87.24% <ø> (ø)
nifgensystemtests ?
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
niscopesystemtests ?
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests ?
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nidmm/nidmm/session.py 94.44% <ø> (-0.47%) ⬇️

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b5c85...b038f91. Read the comment docs.

@@ -792,6 +792,22 @@
}
]
},
'VectorMemoryType': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no reason for these to be in the Python metadata, they aren't for public use.

Copy link
Collaborator Author

@ni-jfitzger ni-jfitzger Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was surprised that private enums were included in the generated metadata, too.
We might need to update the plugin template.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted it and I've got an internal PR to update the internal metadata so that this won't be included next time.
We'll just skip updating this metadata this time around, since there's no other changes.

I considered updating the internal template expander to exclude private access functions, attributes and enums,, but then I remembered the special case of the "internal" SetRuntimeEnvironment function that we include in our metadata and didn't want to risk breaking a similar case with "private" access.

@ni-jfitzger ni-jfitzger added this to the nimi-python 1.4.9 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants