-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure show image actionhandler is only called once #146
Conversation
R0Wi
commented
Jun 2, 2024
- Fix The "close" button in the upper right corner has no function. #143
- showImage was called multiple time
- Close listener was therefore also registered multiple times and stopped working
* Fix #143 * showImage was called multiple time * Close listener was therefore also registered multiple times and stopped working Signed-off-by: Robin Windey <ro.windey@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable28 #146 +/- ##
============================================
Coverage 100.00% 100.00%
Complexity 8 8
============================================
Files 1 1
Lines 29 29
============================================
Hits 29 29 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Robin Windey <ro.windey@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-146-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 f2a9f7491152295e3ff9a56a9c902f185dcaf4f8
# Push it to GitHub
git push --set-upstream origin backport-146-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-master Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-stable29 stable29
# Navigate to the new working tree
cd .worktrees/backport-stable29
# Create a new branch
git switch --create backport-146-to-stable29
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 f2a9f7491152295e3ff9a56a9c902f185dcaf4f8
# Push it to GitHub
git push --set-upstream origin backport-146-to-stable29
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-stable29 Then, create a pull request where the |
* Make sure show image actionhandler is only called once * Fix #143 * showImage was called multiple time * Close listener was therefore also registered multiple times and stopped working Signed-off-by: Robin Windey <ro.windey@gmail.com> * Adjust Playwright tests to be NC28 compatible Signed-off-by: Robin Windey <ro.windey@gmail.com> --------- Signed-off-by: Robin Windey <ro.windey@gmail.com>
* Make sure show image actionhandler is only called once * Fix #143 * showImage was called multiple time * Close listener was therefore also registered multiple times and stopped working Signed-off-by: Robin Windey <ro.windey@gmail.com> * Adjust Playwright tests to be NC28 compatible Signed-off-by: Robin Windey <ro.windey@gmail.com> --------- Signed-off-by: Robin Windey <ro.windey@gmail.com>