Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure show image actionhandler is only called once #146

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

R0Wi
Copy link
Member

@R0Wi R0Wi commented Jun 2, 2024

* Fix #143
* showImage was called multiple time
* Close listener was therefore also registered multiple times and stopped working

Signed-off-by: Robin Windey <ro.windey@gmail.com>
@R0Wi R0Wi linked an issue Jun 2, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f492e78) to head (94af56b).
Report is 1 commits behind head on stable28.

Additional details and impacted files
@@             Coverage Diff              @@
##             stable28      #146   +/-   ##
============================================
  Coverage      100.00%   100.00%           
  Complexity          8         8           
============================================
  Files               1         1           
  Lines              29        29           
============================================
  Hits               29        29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Robin Windey <ro.windey@gmail.com>
@R0Wi R0Wi marked this pull request as draft June 2, 2024 15:43
@R0Wi R0Wi marked this pull request as ready for review June 6, 2024 07:19
@R0Wi R0Wi merged commit f2a9f74 into stable28 Jun 6, 2024
24 of 25 checks passed
@R0Wi
Copy link
Member Author

R0Wi commented Jun 6, 2024

The backport to master failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-146-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 f2a9f7491152295e3ff9a56a9c902f185dcaf4f8
# Push it to GitHub
git push --set-upstream origin backport-146-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-master

Then, create a pull request where the base branch is master and the compare/head branch is backport-146-to-master.

@R0Wi
Copy link
Member Author

R0Wi commented Jun 6, 2024

The backport to stable29 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-stable29 stable29
# Navigate to the new working tree
cd .worktrees/backport-stable29
# Create a new branch
git switch --create backport-146-to-stable29
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 f2a9f7491152295e3ff9a56a9c902f185dcaf4f8
# Push it to GitHub
git push --set-upstream origin backport-146-to-stable29
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-stable29

Then, create a pull request where the base branch is stable29 and the compare/head branch is backport-146-to-stable29.

R0Wi added a commit that referenced this pull request Jun 6, 2024
* Make sure show image actionhandler is only called once

* Fix #143
* showImage was called multiple time
* Close listener was therefore also registered multiple times and stopped working

Signed-off-by: Robin Windey <ro.windey@gmail.com>

* Adjust Playwright tests to be NC28 compatible

Signed-off-by: Robin Windey <ro.windey@gmail.com>

---------

Signed-off-by: Robin Windey <ro.windey@gmail.com>
R0Wi added a commit that referenced this pull request Jun 6, 2024
* Make sure show image actionhandler is only called once

* Fix #143
* showImage was called multiple time
* Close listener was therefore also registered multiple times and stopped working

Signed-off-by: Robin Windey <ro.windey@gmail.com>

* Adjust Playwright tests to be NC28 compatible

Signed-off-by: Robin Windey <ro.windey@gmail.com>

---------

Signed-off-by: Robin Windey <ro.windey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "close" button in the upper right corner has no function.
1 participant