Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes #401

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Bug fixes #401

merged 2 commits into from
Apr 23, 2024

Conversation

ritugala
Copy link
Collaborator

@ritugala ritugala commented Apr 23, 2024 •
edited
Loading

Minor Bug Fixes:

  1. It was retrieving the old reranking file - fixed this
  2. Proper Handling failure cases with column selection / too many incorrect transformation

@ritugala ritugala marked this pull request as ready for review April 23, 2024 23:31
@ritugala ritugala requested review from viswavi, saum7800 and neubig April 23, 2024 23:31
neubig
neubig approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@neubig neubig merged commit d4cd23d into main Apr 23, 2024
8 checks passed
@neubig neubig deleted the bug-fixes branch April 23, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neubig neubig neubig approved these changes

@viswavi viswavi Awaiting requested review from viswavi

@saum7800 saum7800 Awaiting requested review from saum7800

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritugala @neubig