-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cmake issues finding the compiler #3402
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the ncurses and readline package versions to use the specific formulae syntax.
Remove specific versioning for ncurses and readline in the Homebrew installation commands.
Adds a command to list Homebrew libraries in the before-all script.
Update the paths for the READLINE_LIBRARY and NCURSES_LIBRARY in the pyproject.toml.
Update the paths for the READLINE_LIBRARY and NCURSES_LIBRARY config settings in the pyproject.toml file to point to the correct locations in the local Homebrew installation.
Set the readline library path to the specific dynamic library location.
Add environment variables for macOS build to specify LDFLAGS and CPPFLAGS for readline and ncurses libraries.
Removes unnecessary comments and echo statements from the before-all script in pyproject.toml.
Adjusts the MACOSX_DEPLOYMENT_TARGET in the cibuildwheel configuration to ensure compatibility with older macOS versions.
Adjusts the LDFLAGS and CPPFLAGS in the CI workflow to correct the linking paths for readline and ncurses. Reinstalls gcc and cmake in the setup script, ensuring proper linking of libraries. Updates the macOS version in the job matrix for compatibility.
Unlink gcc and cmake before linking to ensure proper installation. Add directory listings for Homebrew paths to aid in debugging.
Enhance the build script to detect the architecture and set the appropriate PATH for Apple Silicon and Intel systems. This change ensures that the correct version of GCC is used based on the architecture, improving compatibility and build reliability.
Update the symlink for gcc based on the architecture. For Apple Silicon, it links to the Homebrew gcc-14, and for Intel, it links to the local gcc-14. This change ensures the correct compiler is used for building projects on different architectures. Additionally, improve output messages to include the current gcc path and version for better clarity.
Refactor the build script in `pyproject.toml` to streamline the configuration for Apple Silicon and Intel architectures. Remove unnecessary newline characters in echo statements and add LDFLAGS and CPPFLAGS for both architectures to ensure proper library and include paths.
Python 3.8 reached end-of-life.
Remove commented-out lines and unnecessary commands in the Homebrew installation section of the configuration. Test installation with the standard compiler for maximum compatibility.
Enables the use of Boost and GSL libraries in the build process by uncommenting the relevant configuration options in `pyproject.toml`.
Add optional dependencies for nestml and openmpi in the project configuration. This allows users to easily install these packages when needed, enhancing the flexibility and usability of the project.
Updates the version number in pyproject.toml to reflect the latest development iteration of the nest-simulator project.
Replace the openmpi dependency with mpi4py in pyproject.toml. No pip package for openmpi available. You have to install it in an other way.
Adjusts the Python version requirement from ">=3.8, <4.0" to ">=3.9, <4.0".
…nvironment variables for user site installation Update `nest_vars.sh.in` and `nest-config.in` to set paths using `site.USER_SITE` for user-specific installations. Modify `slistartup.cc` and `module_manager.cpp` to utilize the new `SLI_PATH` environment variable. Adjust GitHub Actions workflow to include macOS 15 in the build matrix and clean up commented-out code.
Updates the project version in `pyproject.toml` to3.8.post0.dev14 to reflect the latest development iteration. Modifies the OS matrix in the GitHub Actions workflow to remove macOS 15, streamlining the build process for supported operating systems.
This PR was opened by mistake. Therefore, it will be closed immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.