Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the websockets terminate issue #4331

Merged

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

Problem Summary:

There is a trivial issue introduced in #4314, the shutdown layer didn't applied to websocket after the PR, which makes it will hung up when server terminate websocket.

What is changed and how it works?

Fix the shutdown handler, make it's default for HTTP and Websocket, since we will always send exit signal in these two scenario, so we can make the code simpler.

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@chenyukang chenyukang requested a review from a team as a code owner January 29, 2024 08:57
@chenyukang chenyukang requested review from doitian and removed request for a team January 29, 2024 08:57
@gpBlockchain
Copy link
Collaborator

gpBlockchain commented Jan 30, 2024

LGTM

@chenyukang chenyukang added this pull request to the merge queue Jan 30, 2024
Merged via the queue into nervosnetwork:develop with commit c012030 Jan 30, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants