Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: Fix RBF fee and celldeps check rule issue with replaced txs and their descendants #4324

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

Problem Summary:

The current RBF fee check rules use the directly conflicted transactions' fee as compare target, but in the child-pay-for-parent scenario, the new transaction with fee large than root transactions but less than all descendant's sum may succeed in RBF rules.

The current celldep check also has a similar issue.

This PR will fix these 2 issue, by adding all the fee of descendants and root transactions and check the celldeps including descendants.

What is changed and how it works?

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@chenyukang chenyukang requested a review from a team as a code owner January 25, 2024 12:12
@chenyukang chenyukang requested a review from doitian January 25, 2024 12:12
@quake quake merged commit c76a0e1 into nervosnetwork:rc/v0.113.x Jan 25, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants