Fix starting scripts from API endpoint #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1923 introduced a change to handle when scripts timeout waiting for data back. However, it missed adjusting for the change in `NervesHubWeb.API.ScriptController` so using the API is broken. This fixes to match that new return value and adds a `504` response if it times out waiting for the script reply
jjcarstens
commented
Mar 3, 2025
Comment on lines
+37
to
+38
| {:ok, io} <- Scripts.Runner.send(device, command) do | ||
| text(conn, io) |
There was a problem hiding this comment.
This is the magic sauce to fix things. The rest is refactor since the nesting was starting to get very deep
|
Thank you! (and sorry) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1923 introduced a change to handle when scripts timeout waiting for data back. However, it missed adjusting for the change in
NervesHubWeb.API.ScriptControllerso using the API is broken.This fixes to match that new return value and adds a
504response if it times out waiting for the script reply.