Encapsulate device connection behaviour #1836
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshk
force-pushed
the
a-device-proxy-rpc-experiment
branch
2 times, most recently
from
fe132cc to
a25889f
Compare
|
👁️ 👃 👁️ Is this just organizational work or are we changing behavior as well? |
joshk
force-pushed
the
a-device-proxy-rpc-experiment
branch
from
d2bee7b to
33c9cd4
Compare
joshk
changed the title
This isn't changing any behavior. Not one test is changed, all tests are passing. This is more organizationally focused, leading up to a bigger set of work focused on enabling different device transports (websocket proxy, mqtt, ) |
And add some specs and docs
joshk
force-pushed
the
a-device-proxy-rpc-experiment
branch
from
5b2512c to
5ea42e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a foundational step towards NervesHub supporting different device transport backends.
The logic for device connections has been better encapsulated in a new module,
DeviceLink.Connections. TheDeviceLinknamespace is intended to be used for further behaviour expansion.These focused modules are easier to test and clearer to understand.
The next steps are to work through the various channel modules and apply a similar pattern.