Remove connect/disconnect messages from the audit logs #1218
Conversation
It's a very large portion of what's in the audit logs table. We should probably be storing these in another way because devices tend to flap online/offline enough with LTE connections.
There was a problem hiding this comment.
For those following - When scaling to lots of devices, this audit event bloats the table and is problematic when trying to load other pages that include audit logs.
Adding an identifier to the telemetry event at least allows some metric and introspection until we figure out how to best handle connect/disconnect
|
I'm debugging an issue right now where having a record of when the hub was online is really nice. I hope we can get this back soon. I can make the "Last Handshake" field to work in the interim. |
|
If anyone is following this, I've learned that there are just fundamental issues with how the audit log is stored and index. Jon alluded to it in his comment. I did not realize how unscaleable the audit log was right now. Manual intervention is necessary to prune logs aggressively to prevent timeouts. This PR provides breathing room to make a proper fix. |
It's a very large portion of what's in the audit logs table. We should probably be storing these in another way because devices tend to flap online/offline enough with LTE connections.