Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] go 1.24 #1275

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
with:
# Required: the version of golangci-lint is required and
# should be specified with patch version.
version: v1.62.2
version: v1.64.5
args: --timeout 5m
github-token: ${{ secrets.GITHUB_TOKEN }}

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.go-base
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Base image for go dependencies, to speed up builds when they haven't changed.
# For more, see https://github.com/neondatabase/go-chef
FROM golang:1.23-alpine AS chef
FROM golang:1.24-alpine AS chef

ARG GO_CHEF_VERSION=v0.1.0
RUN go install github.com/neondatabase/go-chef@$GO_CHEF_VERSION
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/neondatabase/autoscaling

go 1.23.0
go 1.24.0

replace (
github.com/google/gnostic => github.com/google/gnostic v0.7.0
Expand Down
2 changes: 1 addition & 1 deletion neonvm/hack/Dockerfile.generate
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.23
FROM golang:1.24

RUN apt-get update && apt-get install -y patch

Expand Down
2 changes: 1 addition & 1 deletion pkg/reporting/client_azureblob.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ func (r *azureRequest) LogFields() zap.Field {
func (r *azureRequest) Send(ctx context.Context, payload []byte) SimplifiableError {
var err error

opts := azblob.UploadBufferOptions{} //nolint:exhaustruct // It's part of Azure SDK
opts := azblob.UploadBufferOptions{}
_, err = r.client.UploadBuffer(ctx, r.cfg.Container, r.key, payload, &opts)
if err != nil {
return AzureError{Err: err}
Expand Down
6 changes: 3 additions & 3 deletions pkg/reporting/client_azureblobbilling_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func TestAzureClient_send(t *testing.T) {
require.Error(t, o.err)
var azErr AzureError
require.ErrorAs(t, o.err, &azErr)
rErr := &azcore.ResponseError{} //nolint:exhaustruct // OK for tests
rErr := &azcore.ResponseError{}
require.ErrorAs(t, o.err, &rErr)
require.Equal(t, 404, rErr.StatusCode)
},
Expand All @@ -88,7 +88,7 @@ func TestAzureClient_send(t *testing.T) {
name: "can write then read it",
when: func(t *testing.T, i *input) {
_, err := i.client.client.CreateContainer(i.ctx, i.cfg.Container,
&azblob.CreateContainerOptions{}, //nolint:exhaustruct // OK for tests
&azblob.CreateContainerOptions{},
)
require.NoError(t, err)
},
Expand All @@ -97,7 +97,7 @@ func TestAzureClient_send(t *testing.T) {
b := make([]byte, 1000)
const expectedText = "hello, billing data is here"
read, err := o.c.client.DownloadBuffer(o.ctx, "test-container", "test-blob-name", b,
&azblob.DownloadBufferOptions{}, //nolint:exhaustruct // OK for tests
&azblob.DownloadBufferOptions{},
)
b = b[0:read]
require.NoError(t, err)
Expand Down
Loading