Flytt over relevant kode fra familie-felles http #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sillerud
force-pushed
the
http-client
branch
from
1cb5bdf to
2790035
Compare
fredrikmork
reviewed
Feb 25, 2025
| uri: URI, | ||
| ): T { | ||
| if (!respons.statusCode.is2xxSuccessful) { | ||
| secureLogger.info("Kall mot $uri feilet: ${respons.body}") |
There was a problem hiding this comment.
Suggested change
| secureLogger.info("Kall mot $uri feilet: ${respons.body}") | |
| secureLogger.info("Kall mot {} feilet: {}", uri, respons.body) |
| ): T { | ||
| if (!respons.statusCode.is2xxSuccessful) { | ||
| secureLogger.info("Kall mot $uri feilet: ${respons.body}") | ||
| log.info("Kall mot $uri feilet: ${respons.statusCode}") |
| return try { | ||
| val preferredUsername = | ||
| SpringTokenValidationContextHolder().getTokenValidationContext().getClaims("azuread").get("preferred_username") | ||
| return preferredUsername == null |
There was a problem hiding this comment.
`preferredUsername.isNull()` eller lignende?
There was a problem hiding this comment.
Tenker == null er like greit, men har heller ikke tenkt å gjøre så mye endringer her siden dette er copy pasta. Vil uansett kvitte meg med hele dritten 🤠
| ): List<Journalpost> { | ||
| SecureLog.medContext(logContext) { | ||
| info( | ||
| "henter journalposter for bruker med ident ${journalposterForBrukerRequest.brukerId} " + |
| @@ -54,7 +53,9 @@ class PdlClient( | |||
| logger.medContext(logContext) { | |||
| warn("Advarsel ved henting av personinfo fra PDL. Se securelogs for detaljer.") | |||
| } | |||
| secureLogger.warn("Advarsel ved henting av personinfo fra PDL: ${respons.extensions?.warnings}") | |||
| SecureLog.medContext(logContext) { | |||
| warn("Advarsel ved henting av personinfo fra PDL: ${respons.extensions?.warnings}") | |||
sillerud
force-pushed
the
http-client
branch
2 times, most recently
from
2a69b3a to
fe7057f
Compare
amiraliw
previously approved these changes
Feb 25, 2025
sillerud
force-pushed
the
http-client
branch
from
fe7057f to
70fbce1
Compare
fredrikmork
previously approved these changes
Feb 25, 2025
sillerud
force-pushed
the
http-client
branch
from
70fbce1 to
704c5c7
Compare
amiraliw
previously approved these changes
Feb 25, 2025
sillerud
force-pushed
the
http-client
branch
from
704c5c7 to
930fd59
Compare
amiraliw
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.