Homepage: ensure video iframe fits narrow views #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the main problem causing #632 by ensuring that the video iframe doesn't exceed the view width, whether on desktop or mobile. As a result, the video preview image is cropped under mobile, but this is one of the easiest fixes that doesn't involve further design changes. (The video itself, when viewed under mobile / narrow-views, displays w/o being cropped.)
Note that the video preview image is already being cropped, for example, when viewed under a tablet, so I figured that this solution would likely be acceptable.
Preview: https://deploy-preview-633--nats-io.netlify.app/
Screenshots
Before:
After:
These screenshots are generated from Safari 14.0.3.