Skip to content

Commit

Permalink
Revise Serializable.cpp
Browse files Browse the repository at this point in the history
  • Loading branch information
bocchino committed Mar 3, 2025
1 parent b018b85 commit f95e8e8
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions Fw/Types/Serializable.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ void SerializeBufferBase::copyFrom(const SerializeBufferBase& src) {
// destination has to be same or bigger
FW_ASSERT(src.getBuffLength() <= this->getBuffCapacity(), static_cast<FwAssertArgType>(src.getBuffLength()),
static_cast<FwAssertArgType>(this->getBuffLength()));
(void)memcpy(this->getBuffAddr(), src.getBuffAddr(), this->m_serLoc);
(void)memcpy(this->getBuffAddr(), src.getBuffAddr(), static_cast<size_t>(this->m_serLoc));
}

// Copy constructor doesn't make sense in this virtual class as there is nothing to copy. Derived classes should
Expand Down Expand Up @@ -277,7 +277,7 @@ SerializeStatus SerializeBufferBase::serialize(const SerializeBufferBase& val) {
FW_ASSERT(this->getBuffAddr());
FW_ASSERT(val.getBuffAddr());
// serialize buffer
(void)memcpy(&this->getBuffAddr()[this->m_serLoc], val.getBuffAddr(), size);
(void)memcpy(&this->getBuffAddr()[this->m_serLoc], val.getBuffAddr(), static_cast<size_t>(size));
this->m_serLoc += size;
this->m_deserLoc = 0;

Expand Down Expand Up @@ -536,7 +536,7 @@ SerializeStatus SerializeBufferBase::deserialize(U8* buff, FwSizeType& length, S
return FW_DESERIALIZE_SIZE_MISMATCH;
}

(void)memcpy(buff, &this->getBuffAddr()[this->m_deserLoc], storedLength);
(void)memcpy(buff, &this->getBuffAddr()[this->m_deserLoc], static_cast<size_t>(storedLength));

Check warning

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter buff has not been checked.

length = static_cast<FwSizeType>(storedLength);

Expand All @@ -546,7 +546,7 @@ SerializeStatus SerializeBufferBase::deserialize(U8* buff, FwSizeType& length, S
return FW_DESERIALIZE_SIZE_MISMATCH;
}

(void)memcpy(buff, &this->getBuffAddr()[this->m_deserLoc], length);
(void)memcpy(buff, &this->getBuffAddr()[this->m_deserLoc], static_cast<size_t>(length));

Check warning

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter buff has not been checked.
}

this->m_deserLoc += static_cast<Serializable::SizeType>(length);
Expand Down Expand Up @@ -576,7 +576,7 @@ SerializeStatus SerializeBufferBase::deserialize(SerializeBufferBase& val) {
}

FW_ASSERT(this->getBuffAddr());
(void)memcpy(val.getBuffAddr(), &this->getBuffAddr()[this->m_deserLoc], storedLength);
(void)memcpy(val.getBuffAddr(), &this->getBuffAddr()[this->m_deserLoc], static_cast<size_t>(storedLength));

stat = val.setBuffLen(storedLength);

Expand Down Expand Up @@ -656,7 +656,7 @@ SerializeStatus SerializeBufferBase::setBuff(const U8* src, Serializable::SizeTy
} else {
FW_ASSERT(src);
FW_ASSERT(this->getBuffAddr());
memcpy(this->getBuffAddr(), src, length);
memcpy(this->getBuffAddr(), src, static_cast<size_t>(length));

Check warning

Code scanning / CodeQL

Unchecked return value Warning

The return value of non-void function
memcpy
is not checked.
this->m_serLoc = length;
this->m_deserLoc = 0;
return FW_SERIALIZE_OK;
Expand Down

0 comments on commit f95e8e8

Please sign in to comment.