Skip to content

Commit

Permalink
Added assertion on overflowHook() argument
Browse files Browse the repository at this point in the history
  • Loading branch information
DJKessler committed Sep 11, 2024
1 parent 03dbc05 commit c90c999
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Svc/ComQueue/ComQueue.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ void ComQueue::run_handler(const NATIVE_INT_TYPE portNum, U32 context) {
// ----------------------------------------------------------------------

void ComQueue::buffQueueIn_overflowHook(FwIndexType portNum, Fw::Buffer& fwBuffer) {

Check notice

Code scanning / CodeQL

Use of basic integral type Note

portNum uses the basic integral type int rather than a typedef with size and signedness.
FW_ASSERT(portNum >= 0 && portNum < BUFFER_PORT_COUNT, portNum);
this->deallocate_out(portNum, fwBuffer);

Check warning

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter fwBuffer has not been checked.
}

Expand Down

0 comments on commit c90c999

Please sign in to comment.