Fixing issues w.r.t. CI

nasa · Sep 30, 2024 · 672c1af · 672c1af
1 parent f51a9b6
commit 672c1af
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 16 deletions.
diff --git a/Os/Generic/Types/test/ut/MaxHeap/MaxHeapTest.cpp b/Os/Generic/Types/test/ut/MaxHeap/MaxHeapTest.cpp
@@ -9,17 +9,31 @@
 
 TEST(Nominal, Creation) {
     bool ret;
-    Types::MaxHeap heap;
-    ret = heap.create(0);
-    ASSERT_TRUE(ret);
-    ret = heap.create(1000000);
-    ASSERT_TRUE(ret);
-    ret = heap.create(1);
-    ASSERT_TRUE(ret);
-    ret = heap.create(DEPTH);
-    ASSERT_TRUE(ret);
-    ret = heap.create(DEPTH);
-    ASSERT_TRUE(ret);
+    {
+        Types::MaxHeap heap;
+        ret = heap.create(0);
+        ASSERT_TRUE(ret);
+    }
+    {
+        Types::MaxHeap heap;
+        ret = heap.create(1000000);
+        ASSERT_TRUE(ret);
+    }
+    {
+        Types::MaxHeap heap;
+        ret = heap.create(1);
+        ASSERT_TRUE(ret);
+    }
+    {
+        Types::MaxHeap heap;
+        ret = heap.create(DEPTH);
+        ASSERT_TRUE(ret);
+    }
+    {
+        Types::MaxHeap heap;
+        ret = heap.create(DEPTH);
+        ASSERT_TRUE(ret);
+    }
 }
 
 TEST(Nominal, Empty) {

diff --git a/Os/Stub/test/ConditionVariable.hpp b/Os/Stub/test/ConditionVariable.hpp
@@ -47,7 +47,7 @@ class TestConditionVariable : public ConditionVariableInterface {
     TestConditionVariable();
 
     //! \brief default destructor
-    virtual ~TestConditionVariable() override;
+    ~TestConditionVariable() override;
 
     //! \brief copy constructor is forbidden
     TestConditionVariable(const ConditionVariableInterface& other) = delete;

diff --git a/Os/Stub/test/ut/StubTests.cpp b/Os/Stub/test/ut/StubTests.cpp
@@ -44,4 +44,4 @@ TEST(Stub, Directory) {
 int main(int argc, char** argv) {
     ::testing::InitGoogleTest(&argc, argv);
     return RUN_ALL_TESTS();
-}
+}
diff --git a/Os/test/ut/condition/ConditionRules.hpp b/Os/test/ut/condition/ConditionRules.hpp
@@ -78,4 +78,4 @@ struct NotifyAll : public ConcurrentRule<Os::Test::Condition::Tester> {
     void action(Os::Test::Condition::Tester& state  //!< The test state
                 ) override;
 
-};
+};
diff --git a/Os/test/ut/queue/QueueRules.hpp b/Os/test/ut/queue/QueueRules.hpp
@@ -38,7 +38,7 @@ struct SendNotFull : public STest::Rule<Os::Test::Queue::Tester> {
     // ----------------------------------------------------------------------
 
     //! Constructor
-    SendNotFull(bool end_check=true);
+    explicit SendNotFull(bool end_check=true);
 
     // ----------------------------------------------------------------------
     // Public member functions
@@ -89,7 +89,7 @@ struct ReceiveNotEmpty : public STest::Rule<Os::Test::Queue::Tester> {
     // ----------------------------------------------------------------------
 
     //! Constructor
-    ReceiveNotEmpty(bool end_check=true);
+    explicit ReceiveNotEmpty(bool end_check=true);
 
     // ----------------------------------------------------------------------
     // Public member functions
-Original file line number
+Diff line change
@@ Expand Up @@
         void action(Os::Test::Condition::Tester& state  //!< The test state
                     ) override;
-    };
+    };