Revise String.hpp

Remove explicit from char* constructor The autocoder depends on the implicit constructor
nasa · Apr 29, 2024 · 172ebb0 · 172ebb0
1 parent d784350
commit 172ebb0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/Fw/Types/String.hpp b/Fw/Types/String.hpp
@@ -28,7 +28,7 @@ class String final : public StringBase {
 
     explicit String(const StringBase& src) : StringBase() { *this = src; }
 
-    explicit String(const char* src) : StringBase() { *this = src; }
+    String(const char* src) : StringBase() { *this = src; }
 
     ~String() {}
 

diff --git a/Ref/SignalGen/SignalGen.hpp b/Ref/SignalGen/SignalGen.hpp
@@ -40,20 +40,16 @@ namespace Ref {
             F32 Amplitude,
             F32 Phase,
             Ref::SignalType SigType
-        );
+        ) final;
 
         void SignalGen_Toggle_cmdHandler(
             FwOpcodeType opCode, /*!< The opcode*/
             U32 cmdSeq /*!< The command sequence number*/
-        );
+        ) final;
         void SignalGen_Skip_cmdHandler(
             FwOpcodeType opCode, /*!< The opcode*/
             U32 cmdSeq /*!< The command sequence number*/
-        );
-        void SignalGen_GenerateArray_cmdHandler(
-            FwOpcodeType opCode, /*!< The opcode*/
-            U32 cmdSeq /*!< The command sequence number*/
-        );
+        ) final;
 
         //! Handler implementation for command SignalGen_Dp
         //!
@@ -62,7 +58,7 @@ namespace Ref {
             FwOpcodeType opCode, //!< The opcode
             U32 cmdSeq, //!< The command sequence number
             U32 records
-        ) override;
+        ) final;
 
         // ----------------------------------------------------------------------
         // Handler implementations for data products
@@ -72,7 +68,7 @@ namespace Ref {
         void dpRecv_DataContainer_handler(
             DpContainer& container, //!< The container
             Fw::Success::T status //!< The container status
-        ) override;
+        ) final;
 
 
     public: