Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQL-95: Updates Node to version 22 #150

Merged
merged 5 commits into from
Dec 5, 2024
Merged

GQL-95: Updates Node to version 22 #150

merged 5 commits into from
Dec 5, 2024

Conversation

eudoroolivares2016
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 commented Dec 4, 2024

Overview

What is the feature?

Updates node from 18 to 22

What is the Solution?

Updating node on the IaC and deployment assets. Also updated the docker version in bamboo, needed to also do an npm audit fix to resolve some vulnerabilities snyk was throwing an error on

What areas of the application does this impact?

The runtime of the application

Testing

Reproduction steps

  • **Environment for testing:NA
  • **Collection to test with:NA
  1. Ensure that build is working successfully
  2. Regression test the application to ensure it is working a expected

Attachments

Successful build on bamboo on node-22 docker image
image

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2e4c494) to head (f94fa5c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines         2410      2410           
  Branches       274       274           
=========================================
  Hits          2410      2410           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eudoroolivares2016 eudoroolivares2016 marked this pull request as ready for review December 4, 2024 17:30
@eudoroolivares2016 eudoroolivares2016 force-pushed the GQL-95 branch 2 times, most recently from 885203c to c33f8fe Compare December 4, 2024 18:26
…xt time around

GQL-95: Fix indent

GQL-95: Fix yml syntax

GQL-95: Actually fix the yaml now that I have an extension on VS code
@eudoroolivares2016 eudoroolivares2016 merged commit 5db75e7 into main Dec 5, 2024
9 checks passed
@eudoroolivares2016 eudoroolivares2016 deleted the GQL-95 branch December 5, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants