Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQL-61: As a user, I can read and update provider level group permissions #131

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

dmistry1
Copy link
Contributor

Overview

What is the feature?

In MMT, a user reported that even they don't have system level permission they should still be able to view their provider level permission.

What is the Solution?

Updates the rules and checking in shield.

Query

  • If params.tag includes CMR, check if the user has system level permission
  • Else let them read permission

Mutation

  • If params.tag includes CMR, check if the user has system level permission

  • If params.tag does not include CMR and includes some other provider, check if the user has create group permission for that provider

  • If the user does not have a tag, allow them to update.

What areas of the application does this impact?

List impacted areas. SIT/UAT/PROD

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eb4ec41) to head (b3447ad).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #131   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       106    +1     
  Lines         2327      2343   +16     
  Branches       257       262    +5     
=========================================
+ Hits          2327      2343   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmistry1 dmistry1 merged commit 4b76957 into main Jul 31, 2024
8 checks passed
@dmistry1 dmistry1 deleted the GQL-61 branch July 31, 2024 17:14
jmaeng72 pushed a commit that referenced this pull request Aug 8, 2024
…ions (#131)

* GQL-61: Updates the groups acl to check if a user has provider/system permission to update and read

* GQL-61: Adds test for permissions acl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants