Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQL-52: Allow querying for Acls from within a group #127

Merged
merged 2 commits into from
Jun 20, 2024
Merged

GQL-52: Allow querying for Acls from within a group #127

merged 2 commits into from
Jun 20, 2024

Conversation

abbottry
Copy link
Member

Overview

What is the feature?

Adds the ability to query for Acls that belong to a group, from within a group query.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3e61d39) to head (505d858).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2323      2327    +4     
  Branches       257       258    +1     
=========================================
+ Hits          2323      2327    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


const { dataSources } = context

const a = await dataSources.aclSourceFetch(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I think we can just return the dataSource, don't think a const is needed.

return dataSources.aclSourceFetch(
  handlePagingParams({
    ...args,
    permittedGroup: groupId
  }),
  context,
  parseResolveInfo(info)
) 

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, good catch, I was testing something.

@abbottry abbottry requested a review from dmistry1 June 20, 2024 19:29
@@ -137,7 +137,7 @@ export default {
},

catalogItemIdentity: async (source) => {
const { catalogItemIdentity } = source
const { catalogItemIdentity = {} } = source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have to worry about null here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sir, we're good.

@abbottry abbottry merged commit af70617 into main Jun 20, 2024
7 of 8 checks passed
@abbottry abbottry deleted the GQL-52 branch June 20, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants