-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GQL-52: Allow querying for Acls from within a group #127
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 2323 2327 +4
Branches 257 258 +1
=========================================
+ Hits 2323 2327 +4 ☔ View full report in Codecov by Sentry. |
src/resolvers/group.js
Outdated
|
||
const { dataSources } = context | ||
|
||
const a = await dataSources.aclSourceFetch( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I think we can just return the dataSource, don't think a const
is needed.
return dataSources.aclSourceFetch(
handlePagingParams({
...args,
permittedGroup: groupId
}),
context,
parseResolveInfo(info)
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh man, good catch, I was testing something.
@@ -137,7 +137,7 @@ export default { | |||
}, | |||
|
|||
catalogItemIdentity: async (source) => { | |||
const { catalogItemIdentity } = source | |||
const { catalogItemIdentity = {} } = source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have to worry about null here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No sir, we're good.
Overview
What is the feature?
Adds the ability to query for Acls that belong to a group, from within a group query.
Checklist