Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECHOACCESS-158: Add cursor to related collections #124

Closed
wants to merge 1 commit into from

Conversation

mandyparson
Copy link
Contributor

Overview

What is the feature?

This small change is needed in SIT in order to create pagination in Access

What is the Solution?

Adding a cursor to Related Collections

What areas of the application does this impact?

Collection.graphql

Testing

Reproduction steps

  • **Environment for testing: local
  • **Collection to test with: local one
  1. call cursor on Collection >> Related Collections

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • [ x] I have added automated tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • [ x] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f10a930) to head (6d110f4).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2328      2328           
  Branches       259       259           
=========================================
  Hits          2328      2328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mandyparson mandyparson requested review from cgokey, htranho and tle1989 June 3, 2024 19:26
Copy link
Member

@abbottry abbottry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work. Related collections do not support cursors.

@mandyparson
Copy link
Contributor Author

Not needed.

@mandyparson mandyparson closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants