Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQL-48: Add provider id to order options #122

Merged
merged 1 commit into from
May 21, 2024
Merged

GQL-48: Add provider id to order options #122

merged 1 commit into from
May 21, 2024

Conversation

trevorlang
Copy link
Contributor

Overview

What is the feature?

Add provider id to order options

What is the Solution?

Added providerId to the query

What areas of the application does this impact?

orderOption queries

Testing

Reproduction steps

  • Environment for testing: N/A
  • Collection to test with: N/A
  1. Query for a providerId on an order option and confirm it returns as expected

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ffc03a0) to head (e817a76).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2274      2274           
  Branches       249       249           
=========================================
  Hits          2274      2274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abbottry abbottry merged commit 13fcae6 into main May 21, 2024
8 checks passed
@abbottry abbottry deleted the GQL-48 branch May 21, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants