Security Fix: Add explicit bounds check for numCoefficients in AudioFile library #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with NDEBUG, asserts are eliminated, which could lead to buffer overflow via out-of-bounds access to m_msadpcmCoefficients. This adds explicit bounds checks that remain even when assertions are disabled. Similar to the fix for CVE-2018-13440 in the original AudioFile library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a security vulnerability in the AudioFile library that was cloned from libaudiofile but did not receive the security patch applied in the original repository. The original issue was reported and fixed under antlarr/audiofile@c48e4c6. This PR applies the same patch as the one in the original repository to eliminate the vulnerability.
References
antlarr/audiofile@c48e4c6
Similar to CVE-2018-13440