Ensure unit tests don't fail silently #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Apparently for some cases when unit tests fail pFUnit flags them as failures in the terminal, but does not properly exit with an error. This affected two minor unit tests which have been silently failing for the past month. This PR ensures a proper exit by piping the terminal output to a log file, grepping for failures and exiting with a 1 status if these are found.
Bugfixes
Legolas
exit 1
status when the unit testing suite failsFor future reference: Goddard-Fortran-Ecosystem/pFUnit#423
Testing
Unit tests
gcc-9
,gcc-10
,gcc-11
andgcc-12
for unit testing (coverage only with 11)