Added get_samples function to retrieve the acronym #1166
+105
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… assignment to before statement
… assignment to before statement
…aged-when-retrieving-samples-from-drac' of https://github.com/mxcube/mxcubecore into 1156-sample-names-and-protein-acronyms-are-not-well-managed-when-retrieving-samples-from-drac
| @@ -70,6 +71,43 @@ class Session(BaseModel): | |||
| logbook_URL: Optional[str] = None | |||
|
|
|||
|
|
|||
| class Instrument(BaseModel): | |||
There was a problem hiding this comment.
It would in general be very nice with some comments on each field and class, unless its evident what it is. It would make it easier to understand what purpose they have and for others to adopt.
|
It looks like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The acronym is a mandatory parameter for each sample, as it is frequently used when creating the final target folder.
However, it is not retrieved when downloading the puck information, so a second request is made to obtain the sample (or sample sheets) by investigation.
This PR proposes to retrieve such information when the synchronization is triggered as well as a new model has been added to:
model/lims_sessionI wonder if this file should be renamed (to
limsif it groups all models for the lims) or refactored in smaller bits