Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firefox faq about uplifts #293

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Update firefox faq about uplifts #293

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cab94ac
Update firefox faq about uplifts
bcolsson Dec 20, 2024
25c6c35
Address review feedback
bcolsson Jan 6, 2025
709362d
Address additional feedback
bcolsson Jan 18, 2025
f85cb6c
Add review suggestions
bcolsson Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/products/firefox_desktop/firefox_l10n_faqs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ Typically once or twice a week, the quarantined content (in the `update` branch)

While Nightly is always open for new strings, Beta and Release are string frozen, meaning that patches with new strings are normally not allowed to land.

Uplifts need to be evaluated case by case, but in general they should be avoided in the context of a 4-weeks release cycle. Possible alternatives are uplifting ad-hoc patches without string changes, or exposing the feature/change only to English users.
Uplifts need to be evaluated case by case, but in general they should be avoided in the context of a [4-week release cycle](./build_system.md). Possible alternatives are uplifting ad-hoc patches without string changes, or exposing the feature/change only to English users.

In the event an uplift request is made and approved, translations for uplifted strings should also be uplifted if they have landed and have had enough time for localization. For translations to appear in the build, the `revision` value for all locales in [`l10n-changesets.json`](https://searchfox.org/mozilla-central/source/browser/locales/l10n-changesets.json) must have a commit hash containing the appropriate translations from [`firefox-l10n`](https://github.com/mozilla-l10n/firefox-l10n). Typically, the `l10n-changesets.json` file from mozilla-beta is used since it has gone through the build system at least once (even if it isn't the latest). There are two options to ensure these changes are uplifted: an ad-hoc patch including the updates to the `l10n-changesets.json` file or asking Release Management to land a follow-up change for the l10n changesets.

One more thing to consider is the timing of the uplift. The second part of the Beta cycle is completely frozen, meaning that we can’t take any updates to localization and ship it in that version. Anything uplifted close to the deadline, or after, will ship untranslated. For more details about the Beta timeline for l10n, see the [Build system document](build_system.md#timeline-and-deadlines).

Expand Down
Loading